Added support for responsive snapshot capture #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chinmay-browserstack
commented
Sep 27, 2024
chinmay-browserstack
commented
- Added option for responsiveSnapshotCapture. when this option is passed as true, we will capture dom in all widths returned by CLI.
- resize browser window using set_window_size for selenium 3 or non chrome browsers else using cdp to resize window. reason: in chrome we can only resize window upto 500px so to bypass this we are using cdp but running cdp command in selenium 3 is not supported.
- collect cookies using selenium driver.
- Send logs to cli via /percy/log endpoint
chinmay-browserstack
requested review from
pankaj443 and
shantanuk-browserstack
|
why is percy-java-selenium on percy public? |
pankaj443
reviewed
Oct 3, 2024
pankaj443
reviewed
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.