Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bucket IAM Policy implementation #101

Merged
merged 8 commits into from
Feb 4, 2020
Merged

Bucket IAM Policy implementation #101

merged 8 commits into from
Feb 4, 2020

Conversation

jpencola
Copy link
Member

Fixes #63

deepanjan90
deepanjan90 requested changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@deepanjan90 deepanjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well in general, Minor changes requested

jpencola and others added 5 commits February 3, 2020 14:40
@jpencola @deepanjan90
Update src/main/java/gyro/google/storage/BucketIamPolicyBinding.java
93525d1 
Co-Authored-By: Deepanjan Bhattacharyya <bhattacharyya.deepanjan@gmail.com>
@jpencola @deepanjan90
Update src/main/java/gyro/google/storage/BucketIamPolicyBinding.java
d76ea91 
Co-Authored-By: Deepanjan Bhattacharyya <bhattacharyya.deepanjan@gmail.com>
@jpencola @deepanjan90
Update src/main/java/gyro/google/storage/BucketIamPolicyBinding.java
abd0463 
Co-Authored-By: Deepanjan Bhattacharyya <bhattacharyya.deepanjan@gmail.com>
@jpencola @deepanjan90
Update src/main/java/gyro/google/storage/BucketIamPolicyBindingCondit…
8a68cf0 
…ion.java

Co-Authored-By: Deepanjan Bhattacharyya <bhattacharyya.deepanjan@gmail.com>
@jpencola
Implement review feedback.
1f74401
@beetlebugorg beetlebugorg merged commit f52747c into master Feb 4, 2020
@beetlebugorg beetlebugorg deleted the feature/bucket-iam-policy branch February 4, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepanjan90 deepanjan90 deepanjan90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCP: Bucket IAM Policy
3 participants
@jpencola @deepanjan90 @beetlebugorg