GCP: Compute Routers #155
Merged
GCP: Compute Routers #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
src/main/java/gyro/google/compute/RouterNatSubnetworkToNat.java
Outdated
Show resolved
Hide resolved
deepanjan90
reviewed
Apr 13, 2020
src/main/java/gyro/google/compute/RouterNatSubnetworkToNat.java
Outdated
Show resolved
Hide resolved
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
deepanjan90
reviewed
Apr 13, 2020
Use newSubResource. Refactor unnecessary null checks. Initialize null values to empty lists. clear lists before refreshing.
deepanjan90
reviewed
Apr 14, 2020
Comment on lines
95
to
96
| setSourceIpRangesToNat(model.getSourceIpRangesToNat() == null ? new ArrayList<>() : model.getSourceIpRangesToNat()); | ||
| setSecondaryIpRangeNames(model.getSecondaryIpRangeNames() == null ? new ArrayList<>() : model.getSecondaryIpRangeNames()); |
deepanjan90
reviewed
Apr 14, 2020
| .collect(Collectors.toList())); | ||
| } | ||
|
|
||
| getSubnet().clear(); |
deepanjan90
reviewed
Apr 14, 2020
| protected void doDelete(GyroUI ui, State state) throws Exception { | ||
| Compute client = createComputeClient(); | ||
|
|
||
| client.routers().delete(getProjectId(), getRegion(), getName()).execute(); |
There was a problem hiding this comment.
waitForCompletion(client, operation);
deepanjan90
reviewed
Apr 14, 2020
| .collect(Collectors.toList())); | ||
| } | ||
|
|
||
| client.routers().patch(getProjectId(), getRegion(), getName(), router).execute(); |
There was a problem hiding this comment.
waitForCompletion(client, operation);
deepanjan90
reviewed
Apr 14, 2020
| router.setNetwork(getNetwork().getSelfLink()); | ||
| } | ||
|
|
||
| Operation operation = client.routers().insert(getProjectId(), getRegion(), router).execute(); |
There was a problem hiding this comment.
waitForCompletion(client, operation);
deepanjan90
requested review from
beetlebugorg and
deepanjan90
and removed request for
beetlebugorg and
deepanjan90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144