U24: Apache service restarted to often during installation process

[laeti-tia]

Installation of the toolkit on U24 results in the apache2 service to froze because restarted too often by our different packages. I see this error in the installation output:

Setting up perfsonar-psconfig-publisher (5.2.0~a1.0~20240925011021-1) ...
apache2_invoke ssl: already enabled
Job for apache2.service failed.
See "systemctl status apache2.service" and "journalctl -xeu apache2.service" for details.
invoke-rc.d: initscript apache2, action "restart" failed.
× apache2.service - The Apache HTTP Server
     Loaded: loaded (/usr/lib/systemd/system/apache2.service; enabled; preset: enabled)
     Active: failed (Result: start-limit-hit) since Wed 2024-09-25 13:54:14 UTC; 13ms ago
   Duration: 883ms
       Docs: https://httpd.apache.org/docs/2.4/
    Process: 16961 ExecStart=/usr/sbin/apachectl start (code=exited, status=0/SUCCESS)
    Process: 17232 ExecReload=/usr/sbin/apachectl graceful (code=exited, status=0/SUCCESS)
    Process: 17536 ExecStop=/usr/sbin/apachectl graceful-stop (code=exited, status=0/SUCCESS)
   Main PID: 16964 (code=exited, status=0/SUCCESS)
        CPU: 1.089s

Sep 25 13:54:13 psu24 systemd[1]: Reloaded apache2.service - The Apache HTTP Server.
Sep 25 13:54:14 psu24 systemd[1]: Stopping apache2.service - The Apache HTTP Server...
Sep 25 13:54:14 psu24 apachectl[17538]: [Wed Sep 25 13:54:14.380965 2024] [proxy:warn] [pid 17538:tid 140540223506304] AH01146: Ignoring parameter 'status=+I' for worker 'http://localhost:3000' because of worker sharing
Sep 25 13:54:14 psu24 apachectl[17538]: AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using 172.17.0.2. Set the 'ServerName' directive globally to suppress this message
Sep 25 13:54:14 psu24 systemd[1]: apache2.service: Deactivated successfully.
Sep 25 13:54:14 psu24 systemd[1]: Stopped apache2.service - The Apache HTTP Server.
Sep 25 13:54:14 psu24 systemd[1]: apache2.service: Consumed 1.089s CPU time, 61.2M memory peak, 0B memory swap peak.
Sep 25 13:54:14 psu24 systemd[1]: apache2.service: Start request repeated too quickly.
Sep 25 13:54:14 psu24 systemd[1]: apache2.service: Failed with result 'start-limit-hit'.
Sep 25 13:54:14 psu24 systemd[1]: Failed to start apache2.service - The Apache HTTP Server.

We probably have 2 different ways to solve that. The first one would be brute force by calling systemctl reset-failed apache2.service before every restart we do in the packages.

The second solution, probably better but that would require more changes, would be to regroup all apache2 service restarts in a single place at the end of the installation process. We'll need to find the best way of doing that.

[laeti-tia]

Rerunning the install process when it fails makes it finish fine. It's already something…

[laeti-tia]

Reordering the apache2_invoke commands and forcing a single restart per service seems to solve this issue (see the above 3 commits). This might be all we need after all.

To be tested better.

[laeti-tia]

Generalising to all postinst scripts dealing with apache2. My latest install seems to confirm this works.