Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.19]: Add export to cachegrind format support #302

Draft
wants to merge 4 commits into
base: 0.19.x
Choose a base branch
from

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jul 29, 2020

Idea from tideways/php-xhprof-extension#92


As the licensing is unknown, you need to download the class manually to src folder:

curl -o src/CachegrindConverter.php https://raw.githubusercontent.com/tideways/php-xhprof-extension/Cachegrind/support/src/CachegrindConverter.php

{
parent::__construct($app);
$this->searcher = $searcher;
$this->converter = new CachegrindConverter();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we give a helpful error message when this class doesn't exist? Perhaps with installation instructions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My hope was that @beberlei replies to my request to make it separate composer package:

@glensc glensc closed this Feb 12, 2021
@glensc glensc deleted the branch perftools:0.19.x February 12, 2021 12:24
@glensc
Copy link
Contributor Author

glensc commented Feb 12, 2021

@glensc glensc reopened this Feb 12, 2021
@glensc glensc changed the base branch from master to 0.19.x February 12, 2021 12:36
@glensc glensc changed the title Add export to cachegrind format support [0.19]: Add export to cachegrind format support Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants