Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for LIMIT keyword #197

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Add more tests for LIMIT keyword #197

merged 1 commit into from
Sep 10, 2023

Conversation

pali
Copy link
Member

@pali pali commented Sep 8, 2023

Tests are modified from the pull request perl5-dbi/DBD-mysql#349 done by kebhr.

Tests are modified from the pull request perl5-dbi/DBD-mysql#349 done by kebhr.
@pali
Copy link
Member Author

pali commented Sep 8, 2023

@kebhr I have copied your tests to DBD-MariaDB module, they are passing without any required code modification.

@kebhr
Copy link

kebhr commented Sep 10, 2023

@pali The problem I tried to fix in perl5-dbi/DBD-mysql#349 is already fixed in DBD::MariaDB.
Thus, the test passes for DBD::MariaDB without any code changes.

@pali
Copy link
Member Author

pali commented Sep 10, 2023

@kebhr That is great and I think that it is useful to have a test for it.

@pali pali merged commit c5880e3 into perl5-dbi:master Sep 10, 2023
206 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants