Fixed problem with setting "Step:" to high values #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onsdagens
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Hi, thank you for your contribution. I think we should remove the slider altogether and make this a field only instead, a tiny slider for values between 0-2^32 makes little sense (especially when typically you're looking for something more in the 0-1000 range). For now though, this will do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several problems and weird behaviours arise if step_count is given value much larger than 2^32, this also includes overflow. The artificial border of 2^32 prevents this while still being significantly larger than necessary for regular use