Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Sometimes you need to use
FirstTradedTimestamp
,LastSettledTimestamp
, andLastFundingGrowthGlobal
for statistics. Although I can find them through contract events, I think it would be very convenient if you can use some getters, so I added the following functions:PR Reminders
Be ware of the followings
Contract: make sure the code follows our convention, ex: naming, explicit returns, etc.; if uncertain, discuss with others
Test: make sure tests can cover most normal and edge cases; if not, open follow-up tickets. Also, look out for failed tests and fix them!
CHANGELOG.md: update when external interfaces are changed
Workflow: