Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Selection right-click/long-press menu #78

Merged
merged 32 commits into from
Sep 3, 2024

Conversation

personalizedrefrigerator
Copy link
Owner

@personalizedrefrigerator personalizedrefrigerator commented Aug 26, 2024

Summary

Adds a long-press/right-click menu to the selection tool.

Tasks

  • Localize strings
  • Fix iOS (or touchscreen device in general?) bug — clicking on the "..." with a touchscreen does nothing.
  • Fix paste bug — some devices paste copied vector objects as PNGs.
  • Fix Firefox long-press issue (context menu dismissed).
  • Use a clipboard icon for the "paste" menu item.
  • Handle the case where the menu is opened near the top/bottom of the screen and needs to be moved.
  • Accessibility as described in the MDN article for the menu ARIA role.
  • Automated tests -- some.

Screenshot

screenshot: Selection menu includes "copy to clipboard", "duplicate", and "delete" items

@personalizedrefrigerator personalizedrefrigerator marked this pull request as draft August 26, 2024 06:22
Copy link

github-actions bot commented Aug 26, 2024

Visit the preview URL for this PR (updated for commit 8184bd1):

https://js-draw--pr78-work-add-selection-m-5hpjpe40.web.app

(expires Tue, 10 Sep 2024 23:58:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e560ee6f7bb6b79cb55b42fb4c05e9fd1b5c506e

@personalizedrefrigerator personalizedrefrigerator changed the title Proof of concept: Selection right-click/long-press menu feat: Selection right-click/long-press menu Aug 27, 2024
@personalizedrefrigerator personalizedrefrigerator marked this pull request as ready for review September 3, 2024 22:05
@personalizedrefrigerator personalizedrefrigerator merged commit 4a01dec into main Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant