Minor changes to aikido::io::loadSkeletonFromURDF. #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only try to convert to a FreeJoint if the provided transform is not Identity.
Ponzel
previously approved these changes
May 8, 2018
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
==========================================
- Coverage 80.94% 80.93% -0.02%
==========================================
Files 203 203
Lines 5774 5775 +1
==========================================
Hits 4674 4674
- Misses 1100 1101 +1
|
How about we print a warning in that case? One might pass non-identity transform for fixed joint expecting transformed root body, which is not the case here. |
|
If someone passes a non-identity transform for a fixed joint, it throws an error already, doesn't it? |
|
@Tonkel Ah, that's true. |
jslee02
previously approved these changes
May 8, 2018
gilwoolee
pushed a commit
that referenced
this pull request
Jan 21, 2019
* Take DART Uri in loadSkeletonFromURDF. Only try to convert to a FreeJoint if the provided transform is not Identity. * Update CHANGELOG.md. * Add tests for loadSkeletonFromURDF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Urirather than string. (Strings can be automatically converted toUris.)FreeJointif a transform has been provided. (We might want to loadSkeletons with fixed joints, but wouldn't set a transform in this case.)Before creating a pull request
make formatBefore merging a pull request
CHANGELOG.md