Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloning functionality to StateSpace #422

Merged
merged 15 commits into from
May 18, 2018
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 15, 2018

This PR introduces clone functionality to StateSpace.

Usage:

SO2 so2;

auto s1 = so2.createState();
s1.setAngle(angle);
 
auto s2 = s1.clone(); // or auto s2 = so2.cloneState(s1);

This PR is part of #413 and depends on #419.


Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@codecov
Copy link

codecov bot commented May 15, 2018

Codecov Report

Merging #422 into master will increase coverage by 0.06%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   79.64%   79.71%   +0.06%     
==========================================
  Files         231      231              
  Lines        5960     5990      +30     
==========================================
+ Hits         4747     4775      +28     
- Misses       1213     1215       +2
Impacted Files Coverage Δ
include/aikido/statespace/CartesianProduct.hpp 100% <ø> (ø) ⬆️
include/aikido/statespace/ScopedState.hpp 100% <ø> (ø) ⬆️
include/aikido/statespace/SO3.hpp 100% <ø> (ø) ⬆️
include/aikido/statespace/Rn.hpp 100% <ø> (ø) ⬆️
include/aikido/statespace/SO2.hpp 100% <ø> (ø) ⬆️
include/aikido/statespace/StateSpace.hpp 100% <ø> (ø) ⬆️
include/aikido/statespace/SE2.hpp 100% <ø> (ø) ⬆️
include/aikido/statespace/detail/SO3-impl.hpp 100% <ø> (ø) ⬆️
include/aikido/statespace/SE3.hpp 100% <ø> (ø) ⬆️
src/statespace/StateSpace.cpp 55.55% <0%> (-15.88%) ⬇️
... and 8 more

@jslee02 jslee02 changed the title Add cloning to StateSpace Add cloning functionality to StateSpace May 17, 2018
jslee02 and others added 2 commits May 16, 2018 22:31
# Conflicts:
#	include/aikido/statespace/SO2.hpp
#	src/statespace/SO2.cpp
#	tests/statespace/test_SO2.cpp
@brianhou brianhou merged commit 6f331cd into master May 18, 2018
@brianhou brianhou deleted the enhance/clone_state branch May 18, 2018 17:25
gilwoolee pushed a commit that referenced this pull request Jan 21, 2019
* Fixing const-correctness in state space

* Fixing const-correctness of StateHandle

* Fix implicit conversion of StateHandle to State*

* Undo unnecessary changes

* Remove incorrect comment

* Add clone to StateSpace

* Format code

* Update changelog

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants