Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect spline-conversions #511

Merged
merged 12 commits into from
Feb 22, 2019
Merged

Conversation

gilwoolee
Copy link
Contributor

@gilwoolee gilwoolee commented Feb 22, 2019

We have noticed that we convert Spline to Interpolated incorrectly or treat Spline as if it's only a set of Waypoints. This PR removes all such use cases:
Removes

  • computeKunzTiming(Spline)
  • convertToInterpolated(Spline)
  • concatenate(Spline, Spline)
  • convertToKunzPath(Spline)
  • toR1JointTrajectory(Spline)

Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

…atenate(Spline, Spline), convertToKunzPath(Spline), toR1JointTrajector(Spline)
@gilwoolee gilwoolee added this to the Aikido 0.3.0 milestone Feb 22, 2019
brianhou
brianhou previously approved these changes Feb 22, 2019
Copy link
Contributor

@brianhou brianhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

brianhou
brianhou previously approved these changes Feb 22, 2019
brianhou
brianhou previously approved these changes Feb 22, 2019
@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #511 into master will increase coverage by 0.07%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
+ Coverage   77.67%   77.75%   +0.07%     
==========================================
  Files         262      262              
  Lines        6792     6713      -79     
==========================================
- Hits         5276     5220      -56     
+ Misses       1516     1493      -23
Impacted Files Coverage Δ
src/trajectory/util.cpp 92.25% <ø> (+4.67%) ⬆️
include/aikido/planner/kunzretimer/KunzRetimer.hpp 100% <ø> (ø) ⬆️
src/planner/kunzretimer/KunzRetimer.cpp 70.93% <0%> (-3.47%) ⬇️
src/planner/parabolic/ParabolicUtil.cpp 97.89% <100%> (+5.3%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants