Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #8

Closed
wants to merge 2 commits into from
Closed

Tests #8

wants to merge 2 commits into from

Conversation

Shushman
Copy link

A first attempt at tests for OR_TRAJOPT. A summary of the file:

  • Provided first level tests for PlanToConfiguration, PlanToEndEffectorPose, PlanToIK, PlanToEndEffectorOffset. Using the test values from or_ompl.
  • Miss tests for PlanToTSR as I need to figure out TSRs better.

Issues to note:

  • (Possible bug): The test when done from START_CONFIG to GOAL_CONFIG works but not when done from corresponding end effector poses.
  • Test for end effector offset does not seem to be working as expected - the (x,y,z) after the offset does not seem to be changed according to the displacement vector.

@mkoval
Copy link
Member

mkoval commented Sep 17, 2015

These look like a good start.

However, they are very similar to the planner-agnostic tests we have in prpy. Ideally, you should integrate your improvements to these tests into the prpy tests, when possible. This will let us benefit from them on all of our planners that support these methods. Any tests that are planner-specific (e.g. test trajopt-specific functionality) should stay standalone.

Sorry if this was misleading. We typically have two types of tests for planners:

  1. a test for the raw planner
  2. a test for the prpy wrapper

Unlike most of our planners, we did not write the core C++ code. Therefore, we may only need to test (2).

@mkoval
Copy link
Member

mkoval commented Oct 27, 2015

@lgw903 added Trajopt tests to PrPy in personalrobotics/prpy#213.

@Shushman Can you take a look at that pull request and add any tests that you think are missing? In particular, I definitely want to verify that we are testing the two bugs that you found.

@mkoval mkoval closed this Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants