Reuse postprocessing environments in a safer way. #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged after #278.
The previous implementation of PostProcessPath could potentially generate unbounded numbers of environments, as it could generate a new robot instance every time we cloned into the same environment. (This was still better than the original implementation, which always created a new environment.)
Here, we keep a module-level mapping from environments to postprocessing environments and create them on demand, which guarantees that each cloned environment will have at most one postprocessing environment.