Update Perun demos to go-perun 0.10.6 #17

iljabvh · 2023-03-16T10:19:04Z

No description provided.

…lity to go-perun 0.10.6 * client: Modify go-perun methods * workflow: Set ganache to latest Signed-off-by: Ilja von Hoessle <ilja@perun.network>

matthiasgeihs · 2023-09-04T07:40:37Z

.github/workflows/ci.yml

        run: |
-          docker run --rm --name ganache --detach --publish 8545:8545 ${{ env.gananache-image }} --account $KEY_DEPLOYER,$BALANCE --account $KEY_ALICE,$BALANCE --account $KEY_BOB,$BALANCE --blockTime=5
+          docker run --rm --name ganache --detach --publish 8545:8545 trufflesuite/ganache:latest --account $KEY_DEPLOYER,$BALANCE --account $KEY_ALICE,$BALANCE --account $KEY_BOB,$BALANCE --blockTime=5 --gasPrice=0


You probably want to continue using ${{ env.gananache-image }} as defined above?

Why are you using --gasPrice=0 here?

Cheers!

Hi,
the goal of this PR is to update each demo to go-perun v0.10.6 one after another without breaking any non-updated. Ideally, the versions of the other tools/repositories should be bumped as well. In this case, the payment-channel demo did not work with v6.12.2, as defined in env, so I have changed it to latest. If I would have defined trufflesuite/ganache:latest to be in env, used by every Ethereum demo in this repository, it might have broken the other Ethereum demos in the CI, which we want to avoid.

Concerning the --gasPrice=0 setting, I simply follow the README of that demo. Whether or not this is reasonable, is out of scope of this PR.

Best regards

Concerning the --gasPrice=0 setting, I simply follow the README of that demo. Whether or not this is reasonable, is out of scope of this PR.

I see, might have been an oversight in the review then. I would usually suggest to run without setting gas price to 0, especially in the CI, as it tests for a more realistic setting.

Btw: Tutorial also does not set gas price, which is probably review more carefully.
https://labs.hyperledger.org/perun-doc/go-perun/payment_tutorial/test.html
If you want to be consistent, I suggest you rather change the README.

Regarding the first point: I typically recommend to use a fixed version in the CI, because you will get stable behavior over time. I understand that you want to use different ganache versions (what was the reason again for why the new version doesn't work with the old ganache?), you could still create a variable for the new version as before.

Anyways, not my responsibility anymore :D
Just saw this and thought I added a few comments on this open source review... All the best!

…lity to go-perun 0.10.6 * client: Modify go-perun methods * workflow: Set ganache to latest Signed-off-by: Ilja von Hoessle <ilja@perun.network>

Signed-off-by: Minh Huy Tran <huy.tranminh2804@gmail.com>

…an up Signed-off-by: Minh Huy Tran <huy.tranminh2804@gmail.com>

NhoxxKienn · 2023-12-14T00:58:37Z

app-channel/util.go

@@ -61,7 +61,7 @@ func deployContracts(nodeURL string, chainID uint64, privateKey string) (adj, ah
 		panic(err)
 	}

-	const gasLimit = 2200000 // Must be sufficient for deploying TicTacToe.sol.
+	const gasLimit = 2200000 // Must be sufficient for deploying TicTacToeApp.sol.


this is needed because previous gasLimit is not sufficient to deploy app.

NhoxxKienn · 2023-12-14T01:00:06Z

app-channel/contracts/generate.sh

Update the outdated bindings generation script to the newest version of solc and abigen.

NhoxxKienn · 2023-12-14T01:02:56Z

app-channel/contracts/TicTacToeApp.sol

App need to be upated to solidity 0.8.0 to match the template used by the perun-eth-backend and perun-eth-contracts

Signed-off-by: Minh Huy Tran <huy.tranminh2804@gmail.com>

… update Signed-off-by: Minh Huy Tran <huy.tranminh2804@gmail.com>

…acts still need update Signed-off-by: Minh Huy Tran <huy.tranminh2804@gmail.com>

Signed-off-by: Minh Huy Tran <huy@perun.network>

NhoxxKienn · 2024-04-18T16:39:47Z

WARNING: Payment Channel Dot example depends on perun-polkadot-backend and perun-polkadot-node. The following changes must be made before continuing:

perun-polkadot-pallet PR
Perun-polkadot-node PR (only after pallet was merged and dependency was updated)
Perun-polkadot-backend PR (Only after Node was merged)
Container registry for perun-polkadot-node (Needed to run Payment-Channel-DOT CI)

Afterward, the dependency in payment-channel-dot/go.mod must be passed to a stable version, and also the ci.yml for the payment-channel-dot case.

Note: It is also recommended to update the README.md for payment-channel-dot to use the new polkadot-node registry to avoid cloning and building the repo.

Signed-off-by: Minh Huy Tran <huy@perun.network>

…multiledger-channel demo

NhoxxKienn · 2024-08-20T11:40:04Z

LGTM

NhoxxKienn

LGTM

iljabvh linked an issue Mar 16, 2023 that may be closed by this pull request

☂️ Several example demos are not yet compatible with go-perun 0.10.6 #16

Closed

6 tasks

iljabvh self-assigned this Mar 16, 2023

iljabvh requested a review from janbormet March 16, 2023 10:19

iljabvh assigned iljabvh and unassigned iljabvh Mar 16, 2023

iljabvh force-pushed the update-to-goperun-0.10.6 branch from 1797ba0 to a67ed85 Compare September 3, 2023 19:20

payment-channel: Update go-perun methods used in client for compatibi…

74b8493

…lity to go-perun 0.10.6 * client: Modify go-perun methods * workflow: Set ganache to latest Signed-off-by: Ilja von Hoessle <ilja@perun.network>

iljabvh force-pushed the update-to-goperun-0.10.6 branch from a4c2b77 to 74b8493 Compare September 3, 2023 20:43

iljabvh changed the title ~~Payment channel demo is now compatible with go-perun 0.10.6~~ Update Perun demos to go-perun 0.10.6 Sep 4, 2023

matthiasgeihs reviewed Sep 4, 2023

View reviewed changes

iljabvh and others added 5 commits December 8, 2023 15:06

payment-channel: Update go-perun methods used in client for compatibi…

df49865

…lity to go-perun 0.10.6 * client: Modify go-perun methods * workflow: Set ganache to latest Signed-off-by: Ilja von Hoessle <ilja@perun.network>

merge with change from master

44b44db

Signed-off-by: Minh Huy Tran <huy.tranminh2804@gmail.com>

update appchannel code to go-perun 10.6

99d610d

Signed-off-by: Minh Huy Tran <huy.tranminh2804@gmail.com>

update contract to solidity 0.8.0 and generate new bindings

a67fcf7

remove all generated bin and abi files, modify generate script to cle…

2582122

…an up Signed-off-by: Minh Huy Tran <huy.tranminh2804@gmail.com>

NhoxxKienn force-pushed the update-to-goperun-0.10.6 branch from 7f37f7f to 040fd24 Compare December 14, 2023 00:46

update CI to Go 1.20

6204a66

NhoxxKienn force-pushed the update-to-goperun-0.10.6 branch from c27498f to 6204a66 Compare December 14, 2023 00:54

NhoxxKienn reviewed Dec 14, 2023

View reviewed changes

iljabvh assigned NhoxxKienn Dec 14, 2023

NhoxxKienn added 5 commits January 18, 2024 17:33

refactor(collateralized):remove custom outdated perun client

f20adda

Signed-off-by: Minh Huy Tran <huy.tranminh2804@gmail.com>

refactor(collateralized): update app client to go-perun 0.10.6

118d30b

Signed-off-by: Minh Huy Tran <huy.tranminh2804@gmail.com>

refactor(collateralized channel): update the main_test to go-perun 10.6

ddccb23

Signed-off-by: Minh Huy Tran <huy.tranminh2804@gmail.com>

revert(collateralized): revert contracts to original, wait for future…

f984ee7

… update Signed-off-by: Minh Huy Tran <huy.tranminh2804@gmail.com>

refactor(CI): comment out collateralized channel CI test, smart contr…

f9e43d3

…acts still need update Signed-off-by: Minh Huy Tran <huy.tranminh2804@gmail.com>

NhoxxKienn mentioned this pull request Jan 18, 2024

(Collateralized Channel) Smart Contracts need update to Solidity #19

Open

update payment-channel-dot

ba555aa

Signed-off-by: Minh Huy Tran <huy@perun.network>

NhoxxKienn mentioned this pull request Apr 22, 2024

Update for new Perun-Polkadot-Node (Polkadot v1.9) perun-network/perun-polkadot-backend#20

Merged

NhoxxKienn force-pushed the update-to-goperun-0.10.6 branch from f80a744 to 6d470b5 Compare April 23, 2024 11:04

feat: update Polkadot Node container version

e08ec2c

Signed-off-by: Minh Huy Tran <huy@perun.network>

NhoxxKienn force-pushed the update-to-goperun-0.10.6 branch from 6d470b5 to e08ec2c Compare April 23, 2024 11:05

NhoxxKienn and others added 2 commits April 29, 2024 10:44

chore: update polkadot backend version

13c62cf

Signed-off-by: Minh Huy Tran <huy@perun.network>

chore(go.mod, go.sum): Update go-perun dependency to v0.10.6 for the …

317e16b

…multiledger-channel demo

iljabvh force-pushed the update-to-goperun-0.10.6 branch from 9a33eaf to 317e16b Compare August 20, 2024 11:25

iljabvh requested review from NhoxxKienn and removed request for janbormet August 20, 2024 11:29

NhoxxKienn merged commit ddae35d into master Aug 20, 2024
1 check passed

NhoxxKienn reviewed Aug 20, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Perun demos to go-perun 0.10.6 #17

Update Perun demos to go-perun 0.10.6 #17

iljabvh commented Mar 16, 2023

matthiasgeihs Sep 4, 2023

iljabvh Sep 5, 2023

matthiasgeihs Sep 6, 2023

NhoxxKienn Dec 14, 2023

NhoxxKienn Dec 14, 2023

NhoxxKienn Dec 14, 2023

NhoxxKienn commented Apr 18, 2024 •

edited

Loading

NhoxxKienn commented Aug 20, 2024

NhoxxKienn left a comment

Update Perun demos to go-perun 0.10.6 #17

Update Perun demos to go-perun 0.10.6 #17

Conversation

iljabvh commented Mar 16, 2023

matthiasgeihs Sep 4, 2023

Choose a reason for hiding this comment

iljabvh Sep 5, 2023

Choose a reason for hiding this comment

matthiasgeihs Sep 6, 2023

Choose a reason for hiding this comment

NhoxxKienn Dec 14, 2023

Choose a reason for hiding this comment

NhoxxKienn Dec 14, 2023

Choose a reason for hiding this comment

NhoxxKienn Dec 14, 2023

Choose a reason for hiding this comment

NhoxxKienn commented Apr 18, 2024 • edited Loading

NhoxxKienn commented Aug 20, 2024

NhoxxKienn left a comment

Choose a reason for hiding this comment

NhoxxKienn commented Apr 18, 2024 •

edited

Loading