-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update substrate sdk version to polkadot v1.9 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Minh Huy Tran <huy@perun.network>
This was referenced Apr 22, 2024
Signed-off-by: Minh Huy Tran <huy@perun.network>
Signed-off-by: Minh Huy Tran <huy@perun.network>
Signed-off-by: Minh Huy Tran <huy@perun.network>
Signed-off-by: Minh Huy Tran <huy@perun.network>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
- Coverage 98.68% 97.85% -0.83%
==========================================
Files 9 9
Lines 1138 1213 +75
==========================================
+ Hits 1123 1187 +64
- Misses 15 26 +11 ☔ View full report in Codecov by Sentry. |
DragonDev1906
requested changes
Apr 22, 2024
Signed-off-by: Minh Huy Tran <huy@perun.network>
Signed-off-by: Minh Huy Tran <huy@perun.network>
DragonDev1906
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Substrate SDK version to Polkadot v1.9. By incorporating the latest Polkadot release (v1.9)
As reference: https://github.com/substrate-developer-hub/substrate-node-template
Changes made:
Cargo.toml
Default
for PK and add interfaceTypeInfo
requirement intypes.rs
src/lib.rs
(ex:Event
toRuntimeEvent
+ add#[pallet::without_storage_info]
for struct to specified unknownMaxEncodedLen
parameters, add explicit call_index for each call).weight.rs
conversion from int to fit the new Weight packagetest
, change expected error fromInsufficientBalance
toFundsUnvailabe
for the case insufficient depositing.Important: This PR must be reviewed first before reviewing the PR from Perun-Polkadot-Node because the Node uses a submodule of pallet inside.