Channel #3
Merged
Channel #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements conversion between the types from the backend/go-perun (types.Participant, channel.State, channel.Params) and our wire representation types of the contract-types.
…dd MakeAccountAddress and ToAccountAddress functions. wire: Move MakeAccountAddress and ToAccountAddress to channel/types to avoid cyclic imports.
* Adapt tests to change of type wire: Include initialization of backend and randomizer for go-perun tests * Add tests for ToState, MakeState, ToParams, MakeParams. * Modify error handling wallet: Include NewRandomAddress for go-perun tests go.mod, go.sum: Update stellar/go library commit hash
janbormet
commented
Sep 8, 2023
|
Please adjust the directory structure and place test files next to the code they test. Also use the convention package name e.g. |
* Adjust the remaining subpackages to this change * Change error handling t.Fatal -> require wire: Move test files to wire, rename package wallet: Move Randomizer initialization to wallet/test go.mod, go.sum: Adjust packages to fixes
janbormet
commented
Sep 11, 2023
return errors instead of panic in StellarAsset methods wire: Use methods from go-perun to make allocation for go-perun state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.