-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Giscus comments system #267
base: main
Are you sure you want to change the base?
Conversation
Looks amazing. Perhaps comments could also be excluded for the |
Great minds. See #264 😁 |
A few sample pages:
What do you think @nohwnd? |
LGTM shall we just merge this? |
Can't, see task list in PR details. Using my fork's discussion atm. So waiting on approval and actions from @nohwnd 🙂 |
Ahhh 🤦🏻 |
How should we handle docs version changes? E.g. when we move /docs/* from v5 to v6 in the future, the existing comments made in v5-lifetime will show up on v6-pages which might be rewritten. Options:
|
|
||
return ( | ||
<Head> | ||
<meta name="giscus:backlink" content={canonicalUrl} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always add version here? Maybe possible to get current page version dynamically through useDocusaurusContext()
to avoid hardcoding replace /docs/ with /docs/v5 for stable like we do in _redirects
?
Implements Giscus as comment system for all Docs and Commands-pages. Only index-page is currently excluded.
Comments are stored and managed as discussions in specific category in the docs-repo.
Fix #251
TODO: