Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collision output to teamcity printer #188

Closed
olivernybroe opened this issue Sep 16, 2020 · 5 comments
Closed

Add collision output to teamcity printer #188

olivernybroe opened this issue Sep 16, 2020 · 5 comments

Comments

@olivernybroe
Copy link
Member

Right now when an exception happens when using the teamcity printer, it is not using the nice collision output.

By adding support for that, when running test inside phpstorm, we will see our favorite output format.

@roni-estein
Copy link

Super excited for this!!

@olivernybroe
Copy link
Member Author

So we updated the exception output, however it is still not using collision.

@roni-estein This still might make it just a bit easier to read the exception outpu.
#215

New result:
image
Old result:
image

@olivernybroe
Copy link
Member Author

Before we can get collision output, I think Collision might need some changes so we can call the different methods for rendering exceptions in their nice output.

@nunomaduro
Copy link
Member

This is done?

@olivernybroe
Copy link
Member Author

Nope.

So we changed the output in the teamcity printer to a much nicer looking one.

However I don't think I see the need for collision exception output when running in phpstorm, as you can press the file for seeing the code.

I think we should close this one as a "not right now" state. And if more users show interest we should reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants