Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception output in teamcity printer #215

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

olivernybroe
Copy link
Member

Q A
Bug fix? yes
New feature? no

Our teamcity printer didn't do the cleanup on the exception which phpunit does, so I added that in.

it("fails", function () {
    throw new Exception("fails");
});

It still does not use collision, as I cannot figure out how to make that work. However this will at least help a lot of users with debugging their exceptions.

New result:
image
Old result:
image

@nunomaduro
Copy link
Member

Fell free to merge this @olivernybroe, and tag a new release with this feature.

@olivernybroe olivernybroe merged commit 72041a4 into pestphp:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants