Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-merge pest-plugin-coverage, pest-plugin-expectations, pest-plugin-init #316

Closed
nunomaduro opened this issue Jun 14, 2021 · 5 comments · Fixed by #320
Closed

Re-merge pest-plugin-coverage, pest-plugin-expectations, pest-plugin-init #316

nunomaduro opened this issue Jun 14, 2021 · 5 comments · Fixed by #320

Comments

@nunomaduro
Copy link
Member

I don't think we've made a good decision on splitting pest-plugin-coverage, pest-plugin-expectations, pest-plugin-init to its own package. The goal of this issue, is merge the code again in this repository.

@owenvoke
Copy link
Member

I kind of think expectations is quite nice as a separate plugin. That means you can use it with PHPUnit as well if you wanted. The others I think would be good to merge. 👍🏻

I'm happy to help merge all 3 though.

@nunomaduro
Copy link
Member Author

@owenvoke I think is quite nice - but we don't need it personally.

@owenvoke
Copy link
Member

Cool, that's fine. 👍🏻 I've opened a PR for the init plugin part of this issue: #317

@nunomaduro
Copy link
Member Author

Feel free to merge everything if you are confident on those pull requests... We will run a test when everything is ready.

@Ilyes512
Copy link

Wow... really don't like this move. I really liked pestphp/pest-plugin-expectations as a separate package. I guess I will just add pestphp/pest instead and only use the expectations as I do now.

(Above is just a personal "preference" :) just needed to get it out.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants