Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move Expectations API out of external plugin #320

Merged
merged 1 commit into from
Jun 15, 2021
Merged

feat: move Expectations API out of external plugin #320

merged 1 commit into from
Jun 15, 2021

Conversation

owenvoke
Copy link
Member

@owenvoke owenvoke commented Jun 15, 2021

Q A
Bug fix? no
New feature? yes
Fixed tickets #...

This moves the Pest Expectations plugin into Pest core.

@nunomaduro, let me know if the classes should be in different places. I kind of left most of them in the same location as for the plugin, but not sure if they should be under an Expectations directory or anything (mainly Each, Expectation, HigherOrderExpectation, and OppositeExpectation).

Closes #316

@nunomaduro nunomaduro merged commit 624f6e0 into pestphp:master Jun 15, 2021
@owenvoke owenvoke deleted the feature/expectations branch June 15, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-merge pest-plugin-coverage, pest-plugin-expectations, pest-plugin-init
2 participants