Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates Only plugin to check for CI environment #1082

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

nhaynes
Copy link
Contributor

@nhaynes nhaynes commented Jan 30, 2024

What:

  • Bug Fix
  • New Feature

Description:

Pest v1 had a --ci flag that could be used in CI environments to ignore ->only() calls that were accidentally checked-in to the code base.

This feature looks to have been removed around the release of Pest v2 but it is unlear if it was an intentional choice or simply an omission as a result of a refactor to the ->only() feature. The commit that disabled the feature makes no mention of that intent and remnants of the --ci feature remain in the code base (such as the Environment plugin).

This PR restores the functionality of the --ci flag by updating the Only plugin to check the Environment plugin when it is invoked.

Related:

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I'm not sure if this was intentionally removed (I'd probably assume not).

@nunomaduro nunomaduro merged commit b303f9f into pestphp:2.x Jan 30, 2024
6 of 32 checks passed
@nhaynes nhaynes deleted the fix-ci-flag branch January 30, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants