Add name to description for named datasets

[sshead]

Q	A
Bug fix?	no
New feature?	yes
Fixed tickets

With named datasets, Pest does not currently include the dataset name in test output. This PR inserts the dataset name in the dataset description, so that the output of both the test result and failure messages mimic the PHPUnit format.

For example, given the test:

test('same pest style', function ($val) {
    $this->assertSame(1, $val);
})->with([
    'one' => [1],
    'two' => [2],
]);

the current output includes:

  ✓ same with (1)
  ⨯ same with (2)

  ---

  • Tests\Unit\Datasets > same with (2)

With this PR, the new output is:

  ✓ same with data set "one" (1)
  ⨯ same with data set "two" (2)

  ---

  • Tests\Unit\Datasets > same with data set "two" (2)

The PHPUnit failure output, for a test equivalent to the above, is:

1) DatasetsTest::testSame with data set "two" (2)

[owenvoke]

This looks great to me. 👍 Just wondering if there is ever a time when you would just want the name, without the list of data, probably not though. 🤔

[sshead]

Hmm... With the data, it can make for very long output lines - which you don't care about much if the test passed. But if a test fails, it's nice to see the data that failed, not just the name, in the context of the test suite output. And "only sometimes" would be a bigger refactor.

[owenvoke]

Fair enough, that's fine. 👍 All good in my opinion.

[nunomaduro]

@sshead Can you rebase this pull request? Also, can you add a test that actually uses the feature and prints the output to the snapshot?

[sshead]

Let me know if this wasn't what you were after, or if there's anything else I need to do. (I'm such a part-time "not my day job" dev that this is the first time I've ever force-pushed ... hope I didn't break the world 😅)

[nunomaduro]

Sounds good to me, just left a comment.

[nunomaduro]

Can you use the expectation API here?

[sshead]

Done.

[nunomaduro]

This is ready to merge and tag.

[nunomaduro]

@sshead Congrats, great contribution.