-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(teamcity): Add basic teamcity output format #141
Conversation
fd0c22b
to
75f17bb
Compare
Can you fix static analysis bugs buddy? |
796cf5d
to
0c16942
Compare
This should be ready now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do we need to (or can we) add some tests for this?
Just need to resolve the conflicts and this should be good to merge afaik.
We probably could add some tests to check the output. However the biggest problem with the test is that we have to mimic the fake test case class we create 🙂 Might be worth it thougg as we prob. could use it for other tests also |
…amcity � Conflicts: � phpstan.neon
I have no idea how to fix this rector error tbh 👍 @owenvoke you know how? |
Just investigating that issue, looks like it's due to the It's caused by line 82 of the TeamCity class. Is there any reason for making that a static method? 🤔 Basically converting it to a non-static call fixes the issue, but Oh, I see... it's static because it's a class name string. 😬 I'd change it to something like the following, but then PHPStan complains instead. 🙄 $fileName = forward_static_call([$suiteName, '__getFileName']); |
@owenvoke Sounds like an issue with @TomasVotruba If you have a little time, could you help us on how to solve the rector error? |
Just flying by... Could you report and issue on Rector? With input/output/expected output. If it's a blocker, check the @rectorphp README to exclude single rule (that's what I do to not burden the development process) |
@TomasVotruba Cool, I have created an issue rectorphp/rector#3981 and will ignore the rule for now :) |
c67411c
to
bcc206d
Compare
I would really like to get this out as part of next version. The phpstorm plugin has a bunch of issues which can't be resolved before this is added. |
I thought this was already merged, I think it's fine. 👍 |
@owenvoke I think it should have been merged, but I don't have permission 😅 |
Probably my bad for missing it. 😬 I've now merged it. 🎉 |
Thanks! |
This pull request adds team city output support to pest.
A future pr could be added, so the exception stack trace uses collision format.