feat(teamcity): Add basic teamcity output format

[olivernybroe]

Q	A
Bug fix?	no
New feature?	yes
Fixed tickets	#140

This pull request adds team city output support to pest.

A future pr could be added, so the exception stack trace uses collision format.

[nunomaduro]

Can you fix static analysis bugs buddy?

[olivernybroe]

This should be ready now 👍

[owenvoke]

LGTM! Do we need to (or can we) add some tests for this?

Just need to resolve the conflicts and this should be good to merge afaik.

[olivernybroe]

We probably could add some tests to check the output. However the biggest problem with the test is that we have to mimic the fake test case class we create 🙂

Might be worth it thougg as we prob. could use it for other tests also

[olivernybroe]

I have no idea how to fix this rector error tbh 👍

@owenvoke you know how?

[owenvoke]

Just investigating that issue, looks like it's due to the StaticCallOnNonStaticToInstanceCallRector rector.

It's caused by line 82 of the TeamCity class. Is there any reason for making that a static method? 🤔

Basically converting it to a non-static call fixes the issue, but I'm not sure if you made that static for a reason.

Oh, I see... it's static because it's a class name string. 😬 I'd change it to something like the following, but then PHPStan complains instead. 🙄

$fileName = forward_static_call([$suiteName, '__getFileName']);

[olivernybroe]

@owenvoke Sounds like an issue with StaticCallOnNonStaticToInstanceCallRector maybe?

@TomasVotruba If you have a little time, could you help us on how to solve the rector error?

[TomasVotruba]

Just flying by... Could you report and issue on Rector? With input/output/expected output.

If it's a blocker, check the @rectorphp README to exclude single rule (that's what I do to not burden the development process)

[olivernybroe]

@TomasVotruba Cool, I have created an issue rectorphp/rector#3981 and will ignore the rule for now :)

[olivernybroe]

I would really like to get this out as part of next version.

The phpstorm plugin has a bunch of issues which can't be resolved before this is added.

[owenvoke]

I thought this was already merged, I think it's fine. 👍

[olivernybroe]

@owenvoke I think it should have been merged, but I don't have permission 😅

[owenvoke]

Probably my bad for missing it. 😬 I've now merged it. 🎉

[olivernybroe]

Thanks!