Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 'toStartWith' and 'toEndWith' expectations #187

Merged
merged 3 commits into from
Sep 16, 2020
Merged

feat: add 'toStartWith' and 'toEndWith' expectations #187

merged 3 commits into from
Sep 16, 2020

Conversation

owenvoke
Copy link
Member

@owenvoke owenvoke commented Sep 16, 2020 •
edited
Loading

Q A
Bug fix? no
New feature? yes
Fixed tickets #...

This adds support for the following:

expect('string')->toStartWith('str');

expect('string')->toEndWith('ing');

nunomaduro
nunomaduro approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Just commit those to the website, and merge them.

Once you merge them on the website, and you can merge this pr, update the changelog, and tag a new version. 🥳

Of course, do a tweet 👍

@owenvoke
Copy link
Member Author

Merged on the website repo. 👍🏻 pestphp/website#88 I'll do the rest shortly.

@owenvoke owenvoke merged commit f48694b into pestphp:master Sep 16, 2020
@owenvoke owenvoke deleted the feature/assert-string branch September 16, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro nunomaduro approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owenvoke @nunomaduro