-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matrix datasets #303
Matrix datasets #303
Conversation
Took 1 hour 59 minutes
Took 44 seconds
… datasets Took 42 seconds
Took 39 seconds
Took 3 minutes
Took 3 minutes
Took 7 minutes
This sound promising - and a good feature. Be sure to add a good test suite for this. |
Yep, I'm moving it to draft, in order to write more tests Glad you like it! |
Took 1 hour 6 minutes
@nunomaduro I added a new set of tests, trying to replicate all test cases that were written for single datasets (both unit and feature tests) I also added a new way to add multiple datasets now you can use the original syntax
as well using multiple arguments in a single
what do you think? |
@nunomaduro just refactored a bit and reviewed my code, I think it's ready for a deep review 😄 |
@owenvoke there is a failing test, but it seems an error during the Install Dependencies step is there any way to run it again? |
@fabio-ivona, I've requested a re-run of that workflow and everything seems to be fine. 👍🏻 |
Thanks! just to know, how can I speed up a review of this PR? is there any detail missing? |
# Conflicts: # tests/.snapshots/success.txt
Update: merged code from master and updated test snapshots |
@fabio-ivona Can you update the documentation about this? |
Sure! I'm going to work on it this night |
Thank you! |
@nunomaduro done! pestphp/docs#56 I'm not a great non-code writer, please be merciful 😄 |
my aim is to allow a test to be written like this one:
this will generate a matrix of combination of the two datasets (cartesian product)
this feature allows even more than two datasets:
and will output
obviously the original single-dataset management it is still supported
It supports named datasets
as well as all other types of datasets (closures, shared, ecc. ecc.