Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static hooks #357

Merged
merged 5 commits into from
Jul 26, 2021
Merged

Fix static hooks #357

merged 5 commits into from
Jul 26, 2021

Commits on Jul 22, 2021

  1. test: global "all" hooks must only run once (pestphp#351) 

    in other words, they can only run once per file
    @jordanbrauer
    jordanbrauer committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    79ff332 View commit details
    Browse the repository at this point in the history

  2. fix: prevent the global hooks from piling up (pestphp#351) 

    this happens due to the global `*All()` hooks (before & after) being
defined as static. We should be a good citizen and we need to clean up
our mess for the next person in the test instance constructor
    @jordanbrauer
    jordanbrauer committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    60c0ad0 View commit details
    Browse the repository at this point in the history

  3. style: run linter

    @jordanbrauer
    jordanbrauer committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    b601286 View commit details
    Browse the repository at this point in the history

  4. test: use consistent test descriptors

    @jordanbrauer
    jordanbrauer committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    d217503 View commit details
    Browse the repository at this point in the history

  5. style: split assignment into two lines clarity

    @jordanbrauer
    jordanbrauer committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    863ddea View commit details
    Browse the repository at this point in the history