Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix in Test Repository use method. #97

Merged
merged 4 commits into from
Jun 17, 2020
Merged

Fix in Test Repository use method. #97

merged 4 commits into from
Jun 17, 2020

Conversation

fkraefft
Copy link
Contributor

While loading the class or traits & groups for the given path it overrides the previous configuration. The pest plugins where not loading the traits with the Plugin::use() method.

@fkraefft fkraefft mentioned this pull request Jun 17, 2020
Closed
@nunomaduro
Copy link
Member

@fkraefft Interesting, can you fix tests? Probably add a test for this too?

owenvoke
owenvoke reviewed Jun 17, 2020
View reviewed changes
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few fixes that should resolve the CI. 👍 They are just rector style fixes.

For future reference, you can use composer lint to fix these automatically. 🙂

src/Repositories/TestRepository.php Outdated Show resolved Hide resolved
src/Repositories/TestRepository.php Outdated Show resolved Hide resolved
@nunomaduro
Copy link
Member

@owenvoke He just need to run composer lint to fix all the cs issues locally. 👍

@fkraefft
Copy link
Contributor Author

@nunomaduro @owenvoke done!

@nunomaduro nunomaduro requested a review from owenvoke June 17, 2020 15:16
owenvoke
owenvoke approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Don't think the .vscode/ entry is necessary as that should be in your global ignore file, but 🤷

@nunomaduro nunomaduro merged commit 1c3e820 into pestphp:master Jun 17, 2020
@nunomaduro
Copy link
Member

Version 0.2.1 is out with this fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenvoke owenvoke owenvoke approved these changes

@nunomaduro nunomaduro nunomaduro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fkraefft @nunomaduro @owenvoke