Internal improvements to the IPAM coupling feature #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteeckel
force-pushed
the
fix/ipam-coupling-model
branch
from
7fdcebd
to
8f56da4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
peteeckel
force-pushed
the
fix/ipam-coupling-model
branch
from
27894c9
to
67390a7
Compare
peteeckel
changed the title
peteeckel
force-pushed
the
fix/ipam-coupling-model
branch
2 times, most recently
from
7f48258
to
9c7dd3e
Compare
* Removed the middleware code as it turned out to be too limited for the purpose. More specifically, it is not used for model-level changes to objects, so it doesn't work with Custom Scripts etc. (see issue #105) * All checks and operations are now done in signal handlers for ipam.IPAddress that are part of NetBox DNS. Future releases (dropping support for NetBox < 3.7) could be using CUSTOM_VALIDATORS and PROTECTION_RULES instead. * Testing was extended to cover model-level actions and API level actions to IPAddress objects. * Improved DNS record permission checks. Open issue: * Although actions with missing permissions to delete DNS records work properly in the API and the GUI, the respective tests have to be skipped as they fail in the context of unit testing. Potential reasons include a bug in the test framework. This does not have any functional implications and just affects tests for the deletion of IPAddress objects with missing NetBox DNS (object) permissions.
peteeckel
force-pushed
the
fix/ipam-coupling-model
branch
from
9c7dd3e
to
c6c8859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of quirks around the experimental IPAM coupling feature.
fixes #105
fixes #67
IPAddress.create()no DNS record would be createdThe necessary changes resulted in a major redesign of the underlying middleware and the addition of custom signal handlers for requests on
IPAddressviews. As a result, the code should be more stable and somewhat more concise than before, and better perpared for upcoming developments in the IPAM coupling feature.