Rename the Contact model to RegistrationContact #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteeckel
force-pushed
the
feature/rename-contact-model
branch
4 times, most recently
from
49ef740
to
a227cee
Compare
peteeckel
force-pushed
the
feature/rename-contact-model
branch
2 times, most recently
from
608c9e2
to
36c3527
Compare
peteeckel
force-pushed
the
feature/rename-contact-model
branch
from
36c3527
to
8f68c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the feature to enable the management of domain registration information was introduced, it seemed like a good idea to name the model for the Admin-C, Tech-C etc. "Contact". The idea was that namespacing by the plugin's application name would provide enough separation from the core "Contact" model.
Turned out, that idea was wrong. When Strawberry replaced the old GraphQL package in NetBox, the collisions became apparent as Strawberry does not observe the namespacing by app. This could be worked around, but error messages when creating the strawberry schema remained.
For this reason, this PR renames the "Contact" model to "RegistrationContact", which resolves the issue.
Breaking Change
This is a breaking change. All API and script applications using DNS registration contacts will need to be adjusted. This seems to be a minor price to pay for a cleaner integration into NetBox.
This PR will be merged before NetBox DNS 1.1.0 is released (shortly after the release of NetBox 4.1.0)