Clarify docs for migration of ipam coupling to dnssync #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my Opinion it wasnt clear what to do with the custom fields of the old IPAM coupling. I added a paragraph that clarifies that it doesnt have to be done manually.
peteeckel
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Hi @Stathogon, thanks for this! It's always difficult to write documentation for things you don't need documented for yourself, so this is valuable input.
Could you please just remove the extraneous whitespace between "to the" and "new IPAM DNSSync"?
|
i edited the file in the Commit? im not to familiar with git/github, i hope it achieved what i wanted. Atleast for me it looks fine now |
|
Generally, if you want to make changes to a PR it's sufficient to change files in your local repository, commit and push to GitHub again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
i just migrated my netbox to use DNSSync and was a bit confused what to do with the custom fields. Added a Clarification to the docs so it is easier to see.