Skip to content

Commit

Permalink
Updating proxy library handling due to issues with use in certain env…
Browse files Browse the repository at this point in the history
…ironments
  • Loading branch information
peter-murray authored Oct 15, 2024
1 parent 6c30890 commit 04b9e8f
Show file tree
Hide file tree
Showing 11 changed files with 173 additions and 160 deletions.
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,7 @@

# Node.js / npm
node_modules
lib
lib

# Squid logs
squid
10 changes: 6 additions & 4 deletions dist/main/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/main/index.js.map

Large diffs are not rendered by default.

10 changes: 6 additions & 4 deletions dist/post/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/post/index.js.map

Large diffs are not rendered by default.

183 changes: 86 additions & 97 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
"dependencies": {
"@actions/core": "^1.11.1",
"@actions/github": "^6.0.0",
"https-proxy-agent": "^7.0.5",
"jsonwebtoken": "^9.0.2"
"jsonwebtoken": "^9.0.2",
"undici": "^6.20.1"
},
"devDependencies": {
"@types/jsonwebtoken": "^9.0.7",
Expand Down
8 changes: 7 additions & 1 deletion src/actions/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,13 @@ async function run() {
, httpsProxy = core.getInput('https_proxy')
, ignoreProxy = core.getBooleanInput('ignore_environment_proxy')
;
app = await createApplication(privateKey, applicationId, githubApiBaseUrl, undefined, httpsProxy, ignoreProxy);
app = await createApplication({
privateKey,
applicationId,
baseApiUrl: githubApiBaseUrl,
proxy: httpsProxy,
ignoreEnvironmentProxy: ignoreProxy
});
} catch(err) {
fail(err, 'Failed to initialize GitHub Application connection using provided id and private key');
return;
Expand Down
Loading

0 comments on commit 04b9e8f

Please sign in to comment.