fix(luxon): Settings.defaultZone setter

This add support for 'setter' for Settings.defaultZone, The implementation reason is described here: moment/luxon#548 (comment) https://github.com/moment/luxon/blob/master/src/settings.js#L49 Thanks!
peterblazejewicz · Oct 31, 2020 · ae52a5d · ae52a5d
1 parent 7f31695
commit ae52a5d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/types/luxon/index.d.ts b/types/luxon/index.d.ts
@@ -522,7 +522,7 @@ export namespace Settings {
     let defaultLocale: string;
     let defaultNumberingSystem: string;
     let defaultOutputCalendar: string;
-    const defaultZone: Zone;
+    let defaultZone: Zone;
     let defaultZoneName: string;
     let throwOnInvalid: boolean;
     function now(): number;

diff --git a/types/luxon/luxon-tests.ts b/types/luxon/luxon-tests.ts
@@ -206,14 +206,13 @@ Info.features().relative;
 Settings.defaultLocale;
 Settings.defaultLocale = 'en';
 Settings.defaultZoneName = 'Europe/Paris';
+Settings.defaultZone; // $ExpectType Zone
+Settings.defaultZone = Settings.defaultZone;
 Settings.throwOnInvalid = true;
-Settings.now();
-Settings.now = () => 0;
+Settings.now; // $ExpectType () => number
+Settings.now = () => Date.now() + 3000;
 Settings.resetCaches();
 
-// $ExpectError
-Settings.defaultZone = Settings.defaultZone;
-
 // The following tests were coped from the docs
 // http://moment.github.io/luxon/docs/manual/