-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support to custom random seed #116
Conversation
LGTM! @petercinibulk @ThexXTURBOXx can you throw an eye on this pls?:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some documentation changes
Co-authored-by: Nico Mexis <nico.mexis@kabelmail.de>
Co-authored-by: Nico Mexis <nico.mexis@kabelmail.de>
Good idea. I updated the PR. |
@ThexXTURBOXx What are the implications from not using .secure()? |
Thanks! :)
Coming from a hardware security standpoint, yes, it does matter how they were generated. One could always extract the decrypted data directly from memory, but that was not the point the obfuscation in the first place. |
@ThexXTURBOXx Thank you for the detailed answer! Didn't think about brute forcing patterns in the binary. |
Hello!
I'm using the obfuscate feature from clean builds in CI/CD, but every build is generating different output, so checks that I have for unchanged autogenerated files are failing.
My proposed solution is to provide optionally a seed for the random number generator.