Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: envied generator refactor #57

Merged
merged 19 commits into from
Sep 22, 2023
Merged

chore: envied generator refactor #57

merged 19 commits into from
Sep 22, 2023

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Aug 29, 2023 •
edited
Loading

I have completely refactored the envied_generator and removed all string-style code generation in favour of code_builder and dart_style.

@techouse techouse added the enhancement New feature or request label Aug 29, 2023
@techouse techouse marked this pull request as draft August 30, 2023 07:08
@techouse techouse marked this pull request as ready for review August 30, 2023 21:30
@techouse techouse mentioned this pull request Sep 2, 2023
Closed
@techouse
Copy link
Collaborator Author

techouse commented Sep 3, 2023 •
edited
Loading

@petercinibulk Right, I think this is now ready to be reviewed.

I have replaced generate_line.dart and generate_line_encrypted.dart with generate_field.dart and generate_field_encrypted.dart respectively since they do not generate Strings anymore but Fields. Those Fields are then fed to a ClassBuilder and finally returned as a Stirng using a DartFormatter.

@ThexXTURBOXx would you mind throwing an eye on the refactored encryption part of it https://github.com/petercinibulk/envied/pull/57/files#diff-1b43ffc92fbe6a8e5824fa4943872e161df24cb2ecf1b4b49c8447cf03d6c5d3 😇

@petercinibulk petercinibulk merged commit c262471 into petercinibulk:main Sep 22, 2023
@techouse techouse deleted the chore/envied_generator/refactor branch September 25, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petercinibulk petercinibulk petercinibulk approved these changes

Assignees

@petercinibulk petercinibulk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@techouse @petercinibulk