Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional path build.yaml option #83

Merged
merged 9 commits into from
Jan 3, 2024

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Nov 28, 2023

Supersedes #20 originally authored by @marcel-ploch


Adds option for supporting the following build.yaml

targets:
  $default:
    builders:
      envied_generator|envied:
        options:
          path: .env.test
          override: true 

Only when BOTH override is true and the path is set will the generator resort to using the path provided in this build.yaml.

Marcel Ploch and others added 4 commits January 6, 2023 16:14
# Conflicts:
#	examples/envied_example/.env
#	packages/envied_generator/lib/builder.dart
#	packages/envied_generator/lib/src/generator.dart
@techouse techouse added the enhancement New feature or request label Nov 28, 2023
@techouse techouse changed the title feat: optional path option feat: optional path build.yaml option Nov 28, 2023
@techouse techouse marked this pull request as ready for review November 28, 2023 23:42
@techouse techouse assigned techouse and petercinibulk and unassigned techouse Nov 28, 2023
@techouse
Copy link
Collaborator Author

techouse commented Nov 28, 2023

@marcel-ploch can you throw an eye on it, please?

CC/ @petercinibulk @ThexXTURBOXx

@techouse techouse marked this pull request as draft November 29, 2023 07:33
@marcel-ploch
Copy link

Hey @techouse ,

the PR looks fine to me and does the same as my original implementation.

Kind regards

@techouse
Copy link
Collaborator Author

techouse commented Nov 29, 2023

I'll add some more explicit tests for this later in the evening and mark it ready for review again after that.

@marcel-ploch
Copy link

I can help writing tests if you like.
Just tell me what sort of testcases you have in mind ^^

@techouse techouse closed this Nov 29, 2023
@techouse techouse reopened this Nov 29, 2023
@techouse techouse marked this pull request as ready for review November 29, 2023 19:35
@techouse
Copy link
Collaborator Author

I somehow managed to close this by mistake 🙈

Anyhow, this is ready for review

CC/ @marcel-ploch @petercinibulk @ThexXTURBOXx

# Conflicts:
#	packages/envied/README.md
@petercinibulk petercinibulk merged commit 31d4655 into main Jan 3, 2024
3 checks passed
@techouse techouse deleted the feat/optional_path_option branch January 3, 2024 21:10
@techouse techouse mentioned this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants