-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: once and done #1
base: master
Are you sure you want to change the base?
Conversation
An example of this work can be seen at These changes should be pretty independent of my global plans to create a gopher server on the web. It's just nice for testing to be able to call one request and get a response, so I hope you find it helpful. |
@@ -13,6 +13,26 @@ protocol written in [Go](http://golang.org/) initially based on [gogopherd](http | |||
|
|||
go get -u github.com/peterhellberg/gopher/cmd/gopherd | |||
|
|||
## Compile | |||
|
|||
go build -o gopher.local.native cmd/gopherd/main.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having a Compile section, the Installation section should be updated to use go install github.com/peterhellberg/gopher/cmd/gopherd@latest
instead of go get -u github.com/peterhellberg/gopher/cmd/gopherd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, I don't want to install at this point, I want a local compile. The primary reason is that I can't compile go on my web server (a hosted service I pay for but have little control over), so I am only interested in generating a binary that I can scp up. Installing would put the files in ~/go right? I don't mind documenting an install command.
Also, can you name a binary when you install? golang/go#44469
## Usage | ||
For a standalone server use the following command to run the server on the localhost under port 7070. | ||
|
||
./gopher.local.native \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the binary should be gopherd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you object to the longer names for the cross compiled versions?
Thank you for opening the PR, I've left a few comments as I'm a bit reluctant to bring in all of the changes. |
…ff from go.mod as it is not needed
-once /README.md
-root <path>
when launching