Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing purejavacomm source to avoid insecure http repo #10

Closed

Conversation

WhittlesJr
Copy link

Potential fix for issue #9

@WhittlesJr
Copy link
Author

I'm not sure about that travis failure... says it can't find "lein2."

@WhittlesJr
Copy link
Author

Hmm, well looks like Java 1.7.0_151 OpenJDK doesn't play nice with the github version of purejavacomm. This PR probably isn't going to work out so I'll close it and leave the issue to you.

@WhittlesJr WhittlesJr closed this Nov 14, 2017
@WhittlesJr
Copy link
Author

Trying 1.0.2

@WhittlesJr WhittlesJr reopened this Dec 20, 2017
@WhittlesJr
Copy link
Author

Still not working with openjdk7...

@WhittlesJr
Copy link
Author

WhittlesJr commented Dec 20, 2017

It looks like a version mismatch. purejavacomm is apparently compiled with Java 8 (which maps to major version 52 according to http://javarevisited.blogspot.com/2015/05/fixing-unsupported-majorminor-version.html).

Weird that it works in openjdk6 and oraclejdk7...

@peterschwarz peterschwarz self-assigned this Jan 11, 2018
@WickedShell
Copy link
Contributor

This (the Java 8 issue) is something I struggled with in #7 as well. Changing to 1.0.1 is actually how we worked around it at the time, as 1.0.0 was released for Java 8 only.

Regarding openjdk6 comment if you look at the travis run it didn't swap to jdk6 it was still running 1.8.0_151

@peterschwarz
Copy link
Owner

Is there a way to use lein profiles for the various jdks?

@WickedShell
Copy link
Contributor

@peterschwarz I don't know of one, it appears that OpenJDK 6 was removed from the trusty image and needs to be specifically installed now. travis-ci/travis-ci#8199 (comment)

@peterschwarz
Copy link
Owner

Shame that the developer didn't use maven classifiers for that. Will do some research.

@peterschwarz
Copy link
Owner

Could probably update the travis.yaml with the correct set of JDK options in a separate PR

@WickedShell
Copy link
Contributor

I just sent one in to try that for JDK6, I should have just enabled travis on my clone rather then PR'ing it first... (Sorry)

@peterschwarz
Copy link
Owner

Going to merge in #11 and then you can see if that fixes this issue. If so, I will close this PR and the corresponding issue.

@peterschwarz
Copy link
Owner

The issue seems to be resolve, so I will close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants