Add get-port-names helper to util #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WickedShell
force-pushed
the
wickedshell/util-get-ports
branch
from
db4e806
to
b640170
Compare
|
@peterschwarz rebased, and fixed some bad spelling in the commit message, and Travis now passes, so this should be ready for review. |
peterschwarz
requested changes
Jul 20, 2017
src/serial/util.clj
Outdated
|
|
||
| (defn list-ports | ||
| "Print out the available ports. | ||
| The names printed may be passed to `serial.core/open` as printed." | ||
| [] | ||
| (doall (map #(println (.getName %)) (port-identifiers)))) | ||
| (map println (get-port-names))) |
There was a problem hiding this comment.
map is lazy, so this won't actually print. That's where the doall came in.
There was a problem hiding this comment.
Right, I keep forgetting that when I do that in the repl that would realize it... Sorry about that! Pushed a fix.
It's frequently useful to get the set of the available port names, and then be able to do work over it. This just exposes a helper so that the caller doesn't need to know what a CommPortIdentifier is and how to get it's name.
WickedShell
force-pushed
the
wickedshell/util-get-ports
branch
from
b640170
to
27babd4
Compare
peterschwarz
approved these changes
Jul 20, 2017
|
Is this waiting on anything from me? You've marked it as approved but I'm guessing you aren't waiting on anyone else to comment on it... |
|
Was just waiting on the build, and got a bit distracted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's frequently useful to get the set of the available port names, and then be able to do work over it. This just exposes a helper so that the caller doesn't need to know what a CommPortIdentifier is and how to get it's name.