Skip to content

Commit

Permalink
Fix Fuchsia build configuration.
Browse files Browse the repository at this point in the history
This was missed in the original CL switching |is_posix| to false for
Fuchsia.

Bug: chromium:812974
Change-Id: I532516296c6b6ece9805c2f986c8dded00a798df
Reviewed-on: https://chromium-review.googlesource.com/1011251
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52599}
  • Loading branch information
Steelskin authored and Commit Bot committed Apr 13, 2018
1 parent 1023317 commit b40cc63
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions gni/v8.gni
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ if (is_debug && !v8_optimized_debug) {

# TODO(crbug.com/621335) Rework this so that we don't have the confusion
# between "optimize_speed" and "optimize_max".
if (is_posix && !is_android && !using_sanitizer) {
if (((is_posix && !is_android) || is_fuchsia) && !using_sanitizer) {
v8_add_configs += [ "//build/config/compiler:optimize_speed" ]
} else {
v8_add_configs += [ "//build/config/compiler:optimize_max" ]
Expand All @@ -110,7 +110,7 @@ if (v8_code_coverage && !is_clang) {
]
}

if (is_posix && (v8_enable_backtrace || v8_monolithic)) {
if ((is_posix || is_fuchsia) && (v8_enable_backtrace || v8_monolithic)) {
v8_remove_configs += [ "//build/config/gcc:symbol_visibility_hidden" ]
v8_add_configs += [ "//build/config/gcc:symbol_visibility_default" ]
}
Expand Down

0 comments on commit b40cc63

Please sign in to comment.