Fix error in equality method for bearing elements #1102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1100
An AttributeError occurs when running the analysis of a rotor with ball bearings due to an issue in the
__eq__
method of theBearingElement
class. This method checks for equality between elements but fails when comparing instances of theBallBearingElement
class. The error arises because some arguments used during the initialization of aBallBearingElement
instance (such asn_balls
,d_balls
,fs
, andalpha
) are not stored as attributes of the object, leading to a mismatch in the comparison.To resolve this issue, the list of attributes to be compared in the
__eq__
method was refined. The comparison now uses the intersection of the initialization arguments and the object's attribute names, ensuring that only relevant attributes are considered when checking for equality.