Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the X Axis (Rotor Speed) in Campbell Diagram #1105

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

ViniciusTxc3
Copy link
Collaborator

Now, it's possible change the x axis (rotor speed) with variable speed_units in plot().

import ross as rs
import numpy as np

Q_ = rs.Q_
rotor = rs.rotor_example()
speed = np.linspace(0, 400, 101)
camp = rotor.run_campbell(speed)
fig = camp.plot(
        harmonics=[1, 2],
        damping_parameter="damping_ratio",
        frequency_range=Q_((2000, 10000), "RPM"),
        damping_range=(-0.1, 100),
        frequency_units="Hz",
        speed_units="RPM",
        )

This PR resolve, issue #1087.

@ViniciusTxc3 ViniciusTxc3 self-assigned this Aug 28, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.52%. Comparing base (56f00c1) to head (d743b50).
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1105      +/-   ##
==========================================
- Coverage   84.56%   84.52%   -0.05%     
==========================================
  Files          35       34       -1     
  Lines        7990     7972      -18     
==========================================
- Hits         6757     6738      -19     
- Misses       1233     1234       +1     
Files with missing lines Coverage Δ
ross/results.py 84.11% <ø> (-0.08%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5638f10...d743b50. Read the comment docs.

@raphaeltimbo raphaeltimbo merged commit fa13ef3 into petrobras:main Sep 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants