Pre-emptively cull unsatisfiable interpreter constraints. #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `--interpreter-constraint`s are specified that are unsatisfiable, Pex now either errors if all given interpreter constraints are unsatisfiable or else warns and continues with only the remaining valid interpreter constraints after culling the unsatisfiable ones. Fixes pex-tool#432
jsirois
requested review from
cburroughs,
kaos,
benjyw,
huonw and
sureshjoshi
|
Pants reviewers, you're on here due to pantsbuild/pants#21429 |
benjyw
approved these changes
Sep 19, 2024
Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--interpreter-constraints are specified that are unsatisfiable,Pex now either errors if all given interpreter constraints are
unsatisfiable or else warns and continues with only the remaining valid
interpreter constraints after culling the unsatisfiable ones.
Fixes #432