fix(server+clent): added validitions in both fe and be #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielweinberger
requested changes
Oct 11, 2023
apps/console/src/app/components/api-keys/ProviderApiKeyListItem.tsx
Outdated
Show resolved
Hide resolved
|
Thanks for putting the time @adityapuri75. I've left some feedback. Please make sure to run |
|
Thanks for the feedback @arielweinberger, i have updated the branch as you suggested. i don’t have much experience with the fe but i have took reference from the other files and made changes Please Review. |
apps/console/src/app/components/api-keys/ProviderApiKeyListItem.tsx
Outdated
Show resolved
Hide resolved
…m.tsx Co-authored-by: Ariel Weinberger <Weinberger.Ariel@gmail.com>
|
Hello @arielweinberger thanks for the feedback on my commit, can i start working on issue #238 |
|
@adityapuri75 Please comment there so I can assign it to you. Thanks for this contribution! |
arielweinberger
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208
resolved form validation issue in api field