Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(/description): Encode the token for learn-ocaml 0.13.0+ & Update (testsuite, CI) #28

Merged
merged 3 commits into from
Oct 3, 2021

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Oct 3, 2021

* (learn-ocaml-compute-questions-url):
  Add learn-ocaml-compute-questions-url-token1-compat
  to implement the elisp counterpart of PR
  <ocaml-sf/learn-ocaml#423>
@erikmd erikmd added the enhancement New feature or request label Oct 3, 2021
@erikmd erikmd self-assigned this Oct 3, 2021
@erikmd erikmd force-pushed the encode-token branch 2 times, most recently from fce8595 to e7ea703 Compare October 3, 2021 13:41
erikmd added 2 commits October 3, 2021 15:43
* as this test (with an old learn-ocaml-client binary) is unneeded:

  - learnocaml_image: "ocamlsf/learn-ocaml"
    learnocaml_version: "0.12"
    use_passwd: "false"
    client_version: "0.12"
    allow_failures: false

* anyway, it would now fail with a spurious network error:

  Failed to download ‘melpa’ archive.

  href: https://github.com/pfitaxel/docker-emacs-learn-ocaml-client/runs/3782551913?check_suite_focus=true
@erikmd erikmd changed the title feat(/description): Encode the token for learn-ocaml 0.13.0+ feat(/description): Encode the token for learn-ocaml 0.13.0+ & Update testsuite Oct 3, 2021
@erikmd erikmd changed the title feat(/description): Encode the token for learn-ocaml 0.13.0+ & Update testsuite feat(/description): Encode the token for learn-ocaml 0.13.0+ & Update (testsuite, CI) Oct 3, 2021
@erikmd erikmd merged commit abdc263 into master Oct 3, 2021
@erikmd erikmd deleted the encode-token branch October 3, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant