Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swithc to a managed implementation of HttpListener #289

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jasonxh
Copy link

@jasonxh jasonxh commented Oct 16, 2016

The managed implementation is extracted from Mono, Mono.Net.HttpListener. This enables running KeePassHttp with Wine, which lacks httpapi.dll needed by the native HttpListener implementation. It may also resolve other issues faced with the native implementation as well.

Tested on a Mac with WineBottler 1.8-rc4. Has been very solid. Also briefly tested on a Windows VM with no issues.

@pfn
Copy link
Owner

pfn commented Oct 21, 2016

Thanks, I'll give this a review soon

@pfn
Copy link
Owner

pfn commented Oct 22, 2016

Can you supply direct links to retrieve the (as in canonical sources) Mono.Net.Http dlls?

@pfn
Copy link
Owner

pfn commented Oct 22, 2016

And also remove the dll binaries from the PR (I will retrieve and add them later)

@jasonxh
Copy link
Author

jasonxh commented Oct 22, 2016

I added the download link to README.md. I was seriously considering using nuget to manage dependencies, but plgx is making it complicated.

@pfn
Copy link
Owner

pfn commented Nov 1, 2016

Looks pretty reasonable, I'll look at merging this in and cutting a new release using a managed listener after I get back from vacation in December. Thanks

@neothematrix
Copy link

hello guys! thank you very much for your efforts! any news on this PR? I'm using @jasonxh fork successfully but now the cromeIPass plugin complains that it's not the latest keepasshttp version, having this change merged here would be great so that any update would be automatically picked up! again thanks for your efforts!

@NikolausDemmel
Copy link

NikolausDemmel commented Jan 5, 2018

@jasonxh Am I right to assume that without this KeePassHttp won't work on a Winebottler Keepass setup on mac OS, or do you know of a different workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants