-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swithc to a managed implementation of HttpListener #289
base: master
Are you sure you want to change the base?
Conversation
Thanks, I'll give this a review soon |
Can you supply direct links to retrieve the (as in canonical sources) Mono.Net.Http dlls? |
And also remove the dll binaries from the PR (I will retrieve and add them later) |
I added the download link to README.md. I was seriously considering using nuget to manage dependencies, but plgx is making it complicated. |
Looks pretty reasonable, I'll look at merging this in and cutting a new release using a managed listener after I get back from vacation in December. Thanks |
hello guys! thank you very much for your efforts! any news on this PR? I'm using @jasonxh fork successfully but now the cromeIPass plugin complains that it's not the latest keepasshttp version, having this change merged here would be great so that any update would be automatically picked up! again thanks for your efforts! |
@jasonxh Am I right to assume that without this KeePassHttp won't work on a Winebottler Keepass setup on mac OS, or do you know of a different workaround? |
The managed implementation is extracted from Mono, Mono.Net.HttpListener. This enables running KeePassHttp with Wine, which lacks httpapi.dll needed by the native HttpListener implementation. It may also resolve other issues faced with the native implementation as well.
Tested on a Mac with WineBottler 1.8-rc4. Has been very solid. Also briefly tested on a Windows VM with no issues.