Telegraf updated to 1.6.1, and fixes Redmine #8425

[W0CHP]

Updated to 1.6.1 Final with official gopsutils fix. This fixes https://redmine.pfsense.org/issues/8425

[W0CHP]

Hello? Anyone home? Dear pfSense folks:
All of these Telegraf package issues have been outstanding pfSense bugs reported in early Feb. 2018. I have posted here, issued pull requests, been verbose in the Redmine bug report, as well as the pfSense forum. I have not heard a peep from anyone at pfSense, and it seems impossible to get this fix merged. I am missing something in the process?
Contrarily, my patches to FreeBSD-Ports upstream were committed by the Telegraf port maintainer within 10 minutes.

If the pfSense package maintainer for Telegraf is too busy, etc. I offer to take this package over officially. Even still, how can I get this fix, and subsequent Telegraf updates and fixes merged and available to users in a timely fashion?

Onto the other fixes/updates:

Added (native) PF state table metrics to the config file. This has been a native input plugin since Telegraf ~1.5x - not sure why it was never included in the pfSense package. See my screenshot of the PF metrics enabled in my updated pfSense package.

[rbgarga]

I'll bring latest telegraf version to pfSense ports tree but using git-cherry-pick to make merge processes in the future easier.

@W0CHP is there any necessary adjustment to be done on pfSense-pkg-Telegraf to make it to work with this new version?

[W0CHP]

Hi @rbgarga. Nothing required to make the new version work. However, if users want to track PF table states with Telegraf/InfluxDB, the telegraf.inc file needs one additional line to define the input:

https://github.com/W0CHP/FreeBSD/blob/master/ports/net-mgmt/telegraf/files/usr/local/pkg/telegraf.inc#L83

[W0CHP]

Hello,
I see the patch/Telegraf version upgrade was brought into the 2.4.4a snapshots, but it seems to be missing the pftable state input metric patch I provided. This is nice enhancement to the existing pfSense Telegraf package, since it monitors, well, pf. :-)

I'm wondering if users will at least get the bug fix I provided for Redmine #8425 available 2.4.3-RELEASE?

Sorry for all of the questions; I am unclear of pfSense's/Netgate's expectations of users/contributors providing bug fixes and enhancements. Once I have more understanding of the process and expectations of contributors, I will adjust my mine.

Thanks.

[rbgarga]

Hello @W0CHP

You don't need to care about files inside net-mgmt/telegraf. This is the telegraf port from FreeBSD to provide binaries and we don't change that.

The changes you are proposing must be done on net-mgmt/pfSense-pkg-Telegraf. I've already cherry-picked the upgrade to 1.6.1 from FreeBSD's original commit and I can cherry-pick that to stable branches as well.

Please submit a pull request changing only net-mgmt/pfSense-pkg-Telegraf and I'll be glad to review and commit it

[W0CHP]

OK thanks! Will initiate a fresh new PR.