Make -d and -v actually work, modify pfSense UI

[zmanion]

Code was added to arpwatch to ignore CARP/VRRP MAC addresses when logging but the runtime option (-v) was not enabled. These changes also allow arpwatch to be run with -d for debug. Modify pfSense UI to support -v.

Here's the bug for upstream: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235415. Not sure how pfSense feels about getting out of sync with FreeBSD.

I've tested this on one pfSense system running 2.4.4-RELEASE-p2 and the UI works:

$ pgrep -lf arpwatch
1762 /usr/local/sbin/arpwatch -v -z -f /usr/local/arpwatch/arp_igb3.dat -i igb3 -m foo@example.com
1533 /usr/local/sbin/arpwatch -v -z -f /usr/local/arpwatch/arp_igb2.dat -i igb2 -m foo@example.com
1155 /usr/local/sbin/arpwatch -v -z -f /usr/local/arpwatch/arp_igb0.dat -i igb0 -m foo@example.com

[jim-p]

Are the changes to the arpwatch port necessary? I'm not seeing any functional changes. I'd prefer to not be out of sync with FreeBSD if possible.

[zmanion]

Changes to the port would be necessary, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235415. The port needs to actually accept the -v flag.
I understand not wanting to be out of sync with FreeBSD.

[jim-p]

Looks like the changes to the port were just accepted, which is a good sign.

[rbgarga]

@zmanion I've cherry picked net-mgmt/arpwatch changes from upstream. Could you please remove any change to this port from this Pull Request and keep only changes to net-mgmt/pfSense-pkg-arpwatch ?

[zmanion]

@rbgarga: Done, I left the change to bump PORTVERSION in the Makefile, not sure if that is correct or not.

[rbgarga]

I've manually merged it. Thanks!