drop the msp430.sh shim #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the new asm-args field introduced in rust-lang/rust#38463, we can fix the ABI problem in the target specification itself. As the shim is gone, now the -mmcu flag is passed to the linker using .cargo/config. This commit also adds a build script. This build script will copy the linker scripts from the ldscripts directory to $OUT_DIR. This (a) lets you call the cargo command from a directory different that the root of the Cargo project and (b) opens the possibility of using this crate as a library.
|
New nightly is finally released so I can merge this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new asm-args field introduced in rust-lang/rust#38463, we can
fix the ABI problem in the target specification itself.
As the shim is gone, now the -mmcu flag is passed to the linker using
.cargo/config.
This commit also adds a build script. This build script will copy the
linker scripts from the ldscripts directory to $OUT_DIR. This (a) lets
you call the cargo command from a directory different that the root of
the Cargo project and (b) opens the possibility of using this crate as a
library.
r? @pftbest I didn't update the README. I'll leave that to you 😄. Also this depends on rust-lang/rust#38463.